Run windows examples in linux#2747
Conversation
riccardobl
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new Gradle tasks to download the umu-launcher and a Windows JDK, enabling the execution of jMonkeyEngine examples within a Proton environment. The review feedback highlights several opportunities to make the build script more idiomatic and robust, including declaring input properties for proper incremental builds, using 'ant.get' for more reliable file downloads, and leveraging 'fileTree' for locating binaries. There is also a suggestion to simplify the classpath construction by removing redundant dependency resolutions.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 participant
Since this is the year of the linux desktop, this PR adds a
runExamplesWithProtontaskthat runs the examples through umu-launcher inside proton.
With this we can test jme for windows from any linux machine.